Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1135643002: Remove unneeded AddRef in RenderViewTest::SetUp (Closed)

Created:
5 years, 7 months ago by nasko
Modified:
5 years, 7 months ago
Reviewers:
jam, lfg
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded AddRef in RenderViewTest::SetUp The AddRef in RenderViewTest::SetUp is not needed and can lead to leaks in tests. RenderView takes a reference on itself during initialization and drops it in RenderWidget::Close (which it inherits & calls directly). TBR=jam@chromium.org BUG=357747 Committed: https://crrev.com/c27ac70fabb2f93aeb486b783c170bbaee7f7304 Cr-Commit-Position: refs/heads/master@{#328991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/public/test/render_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
nasko
Hey John, Can you review this CL for me? Thanks in advance! Nasko
5 years, 7 months ago (2015-05-07 23:04:16 UTC) #2
nasko
The CredentialManager... test failures are going to be fixed by https://codereview.chromium.org/1124393003/ (currently in CQ).
5 years, 7 months ago (2015-05-07 23:06:08 UTC) #3
nasko
Hey Lucas, Can you review this CL for me? You've been digging into how RenderView/RenderWidget ...
5 years, 7 months ago (2015-05-08 17:44:10 UTC) #5
lfg
On 2015/05/08 17:44:10, nasko wrote: > Hey Lucas, > Can you review this CL for ...
5 years, 7 months ago (2015-05-08 18:18:10 UTC) #6
nasko
Thanks for the review. I'll move John to TBR, since between lfg@ and myself I ...
5 years, 7 months ago (2015-05-08 18:22:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135643002/1
5 years, 7 months ago (2015-05-08 18:23:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 18:28:16 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 18:29:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c27ac70fabb2f93aeb486b783c170bbaee7f7304
Cr-Commit-Position: refs/heads/master@{#328991}

Powered by Google App Engine
This is Rietveld 408576698