Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1124393003: Fix cleanup in CredentialManagerClientTest (Closed)

Created:
5 years, 7 months ago by nasko
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cleanup in CredentialManagerClientTest CredentialManagerClientTest allocates a client and a credential in test setup, but doesn't free the client in the teardown. BUG= Committed: https://crrev.com/4cf7a62e423cdff018ffa3c4a60e5c7df0068fc8 Cr-Commit-Position: refs/heads/master@{#328878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Hey Mike, Can you review this CL for me? It balances the allocation in test ...
5 years, 7 months ago (2015-05-07 22:56:32 UTC) #2
Mike West
LGTM!
5 years, 7 months ago (2015-05-07 23:01:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124393003/1
5 years, 7 months ago (2015-05-07 23:04:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 23:31:10 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 23:32:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cf7a62e423cdff018ffa3c4a60e5c7df0068fc8
Cr-Commit-Position: refs/heads/master@{#328878}

Powered by Google App Engine
This is Rietveld 408576698