Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3070)

Unified Diff: tools/perf/measurements/session_restore_with_url.py

Issue 113563004: Add perf tests for starting Chrome with URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test descriptions in start_with_url Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/session_restore_with_url.py
diff --git a/tools/perf/measurements/session_restore_with_url.py b/tools/perf/measurements/session_restore_with_url.py
new file mode 100644
index 0000000000000000000000000000000000000000..751949acb064b092ec43ba0e9b04fa935512432e
--- /dev/null
+++ b/tools/perf/measurements/session_restore_with_url.py
@@ -0,0 +1,19 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from measurements import session_restore
+
+
+class SessionRestoreWithUrl(session_restore.SessionRestore):
+
+ def __init__(self):
+ super(SessionRestoreWithUrl, self).__init__()
+
+ def CanRunForPage(self, page):
+ # The session restore tests ignore the contents of the page set, so only
jeremy 2013/12/17 11:29:44 nit s/so/so they/
aberent 2013/12/17 17:31:27 Actually changing the function to check that the p
+ # run for the first page in the set. This test, however, uses the
+ # set_startup_url attribute of pages in the page set, which may differ
+ # between the pages so it makes sense to run it for every page in the page
jeremy 2013/12/17 11:29:44 nit: How about changing this to something like -
aberent 2013/12/17 17:31:27 See above
+ # set.
+ return True

Powered by Google App Engine
This is Rietveld 408576698