tools/perf/measurements/session_restore_with_url.py - Issue 113563004: Add perf tests for starting Chrome with URL

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/session_restore_with_url.py

Issue 113563004: Add perf tests for starting Chrome with URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test descriptions in start_with_url Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/perf/benchmarks/session_restore_with_url.py ('K') | « tools/perf/measurements/session_restore.py ('k') | tools/perf/measurements/startup.py » ('j') | tools/perf/page_sets/startup_pages.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from measurements import session_restore

	6

	7

	8 class SessionRestoreWithUrl(session_restore.SessionRestore):

	9

	10 def __init__(self):

	11 super(SessionRestoreWithUrl, self).__init__()

	12

	13 def CanRunForPage(self, page):

	14 # The session restore tests ignore the contents of the page set, so only
	jeremy 2013/12/17 11:29:44 nit s/so/so they/ nit s/so/so they/ aberent 2013/12/17 17:31:27 Actually changing the function to check that the p Show quoted text On 2013/12/17 11:29:44, jeremy wrote: > nit s/so/so they/ Actually changing the function to check that the page has a startup url, hence rewriting the comment completely.
	15 # run for the first page in the set. This test, however, uses the

	16 # set_startup_url attribute of pages in the page set, which may differ

	17 # between the pages so it makes sense to run it for every page in the page
	jeremy 2013/12/17 11:29:44 nit: How about changing this to something like - nit: How about changing this to something like - pages. The test needs to be run for every page in the set to pick up the individual attributes. aberent 2013/12/17 17:31:27 See above Show quoted text On 2013/12/17 11:29:44, jeremy wrote: > nit: How about changing this to something like - > > pages. The test needs to be run for every page in the set to pick up the > individual attributes. See above
	18 # set.

	19 return True

OLD	NEW