Do not compare case-insensitive for 16bit pseudo identifier

Do not compare case-insensitive for 16bit pseudo identifier

Do not lower the 16-bit pseudo identifiers, they can't match the
internal recognized pseudo names which are all ASCII.
Relevant spec information [1]:
"All CSS syntax is case-insensitive within the ASCII range (i.e.,
[a-z] and [A-Z] are equivalent), except for parts that are not
under the control of CSS."

Test taken from:
https://test.csswg.org/source/css21/syntax/case-sensitive-003.xht

Behavior matches Firefox.

[1] http://www.w3.org/TR/CSS21/syndata.html#characters

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195169

[rwlbuis, 2015-05-07 22:57:00]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-05-07 22:57:01]

PTAL

[Timothy Loh, 2015-05-08 01:26:11]

On 2015/05/07 22:57:01, rwlbuis wrote:
> PTAL

Is there a function that lowercases ASCII characters only? This probably works
because the CSSParserString -> String conversion uses
StringImpl::create8BitIfPossible, so the String object will be 8 bit exactly
when it only contains ASCII characters, but it might be nicer to not depend on
this.

[rwlbuis, 2015-05-08 14:41:07]

On 2015/05/08 01:26:11, Timothy Loh wrote:
> On 2015/05/07 22:57:01, rwlbuis wrote:
> > PTAL
> 
> Is there a function that lowercases ASCII characters only? This probably works
> because the CSSParserString -> String conversion uses
> StringImpl::create8BitIfPossible, so the String object will be 8 bit exactly
> when it only contains ASCII characters, but it might be nicer to not depend on
> this.

I took a quick look but it does not seem there is a way to lowercase ASCII only.
The lower in StringImpl handles both 8bit and 16bit cases, using foldCase for
16bit.

Note that we can postpone this lower code to CSSSelector::parsePseudoType, but I
don't think that is much better.

[Timothy Loh, 2015-05-10 23:26:16]

On 2015/05/08 14:41:07, rwlbuis wrote:
> On 2015/05/08 01:26:11, Timothy Loh wrote:
> > On 2015/05/07 22:57:01, rwlbuis wrote:
> > > PTAL
> > 
> > Is there a function that lowercases ASCII characters only? This probably
works
> > because the CSSParserString -> String conversion uses
> > StringImpl::create8BitIfPossible, so the String object will be 8 bit exactly
> > when it only contains ASCII characters, but it might be nicer to not depend
on
> > this.
> 
> I took a quick look but it does not seem there is a way to lowercase ASCII
only.
> The lower in StringImpl handles both 8bit and 16bit cases, using foldCase for
> 16bit.
> 
> Note that we can postpone this lower code to CSSSelector::parsePseudoType, but
I
> don't think that is much better.

lgtm

[rwlbuis, 2015-05-11 02:24:36]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-05-11 02:24:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135563002/20001

[commit-bot: I haz the power, 2015-05-11 06:36:11]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195169