Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: Source/core/css/parser/CSSSelectorParser.cpp

Issue 1135563002: Do not compare case-insensitive for 16bit pseudo identifier (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css/case-sensitive-003-expected.xhtml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSSelectorParser.cpp
diff --git a/Source/core/css/parser/CSSSelectorParser.cpp b/Source/core/css/parser/CSSSelectorParser.cpp
index 17e6a1a54dc839b426bd93208ba797b61df7b6d6..6b50c6e82d7a0b40d70743a3dd3621e51862e33e 100644
--- a/Source/core/css/parser/CSSSelectorParser.cpp
+++ b/Source/core/css/parser/CSSSelectorParser.cpp
@@ -278,7 +278,8 @@ PassOwnPtr<CSSParserSelector> CSSSelectorParser::consumePseudo(CSSParserTokenRan
OwnPtr<CSSParserSelector> selector = CSSParserSelector::create();
selector->setMatch(colons == 1 ? CSSSelector::PseudoClass : CSSSelector::PseudoElement);
- selector->setValue(AtomicString(String(token.value()).lower()));
+ String value = token.value();
+ selector->setValue(AtomicString(value.is8Bit() ? value.lower() : value));
if (token.type() == IdentToken) {
range.consume();
« no previous file with comments | « LayoutTests/fast/css/case-sensitive-003-expected.xhtml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698