Issue 1135393007: cc: Add property tree verification for compositor thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1135393007: cc: Add property tree verification for compositor thread (Closed)

Created:
5 years, 7 months ago by enne (OOO)

Modified:
5 years, 7 months ago

Reviewers:
Ian Vollick, ajuma

CC:
cc-bugs_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@compproptree_1_turn_off_verification

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

cc: Add property tree verification for compositor thread Depends on https://codereview.chromium.org/1134753005 to turn off verify_property_trees everywhere so that this doesn't break the world. This verification is turned off by default, and can be enabled locally everywhere by reverting the above patch. R=ajuma@chromium.org,vollick@chromium.org BUG=481585 Committed: https://crrev.com/073719864cd7b9af3ae19aa023d32a42a27e631d Cr-Commit-Position: refs/heads/master@{#330639}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -31 lines)			Patch
	M	cc/trees/layer_tree_host_common.cc	View		2 chunks	+40 lines, -31 lines	0 comments	Download

Total messages: 7 (1 generated)

Ian Vollick

On 2015/05/19 at 13:19:17, ajuma wrote: > lgtm lgtm, too.

5 years, 7 months ago (2015-05-19 13:48:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135393007/1

5 years, 7 months ago (2015-05-19 21:30:25 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 22:37:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/073719864cd7b9af3ae19aa023d32a42a27e631d
Cr-Commit-Position: refs/heads/master@{#330639}