Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1134753005: Turn off verification for property trees (Closed)

Created:
5 years, 7 months ago by enne (OOO)
Modified:
5 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off verification for property trees As a part of staging the launch of property trees for the compositor thread, first turn off verification entirely. The next steps are to locally fix problems when verification is on for the compositor thread, and then turn it back on. Another option would be separate main/compositor thread verification flags, but that's more complicated. Additionally, main thread verification does very little except in a few cc unit tests, as launching main thread property trees disabled most verification. Depends on https://codereview.chromium.org/1136643006. R=ajuma@chromium.org,vollick@chromium.org,mkwst@chromium.org BUG=481585 Committed: https://crrev.com/f70294138acf31b83a1db00798ba523c69333c56 Cr-Commit-Position: refs/heads/master@{#330608}

Patch Set 1 #

Patch Set 2 : Turn off in all the places #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M cc/test/fake_layer_tree_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
enne (OOO)
5 years, 7 months ago (2015-05-18 17:59:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753005/1
5 years, 7 months ago (2015-05-18 18:00:25 UTC) #3
enne (OOO)
I should also mention that I explicitly did not turn off the verify_property_trees setting in ...
5 years, 7 months ago (2015-05-18 18:15:35 UTC) #4
Mike West
content/shell LGTM, as long as Blink's layout tests continue to pass.
5 years, 7 months ago (2015-05-18 20:25:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 21:20:38 UTC) #7
enne (OOO)
On 2015/05/18 at 18:15:35, enne wrote: > I should also mention that I explicitly did ...
5 years, 7 months ago (2015-05-18 22:58:12 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753005/20001
5 years, 7 months ago (2015-05-18 23:02:08 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/90196)
5 years, 7 months ago (2015-05-19 00:06:13 UTC) #13
ajuma
lgtm
5 years, 7 months ago (2015-05-19 13:14:43 UTC) #14
Ian Vollick
On 2015/05/19 at 13:14:43, ajuma wrote: > lgtm lgtm, too.
5 years, 7 months ago (2015-05-19 13:36:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134753005/20001
5 years, 7 months ago (2015-05-19 19:55:39 UTC) #17
enne (OOO)
On 2015/05/18 at 20:25:42, mkwst wrote: > content/shell LGTM, as long as Blink's layout tests ...
5 years, 7 months ago (2015-05-19 20:15:59 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 21:25:13 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:26:11 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f70294138acf31b83a1db00798ba523c69333c56
Cr-Commit-Position: refs/heads/master@{#330608}

Powered by Google App Engine
This is Rietveld 408576698