Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1135393002: Version 4.4.63.1 (cherry-pick) (Closed)

Created:
5 years, 7 months ago by Michael Hablich
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.4
Target Ref:
refs/pending/branch-heads/4.4
Project:
v8
Visibility:
Public.

Description

Version 4.4.63.1 (cherry-pick) Merging this two commits into 4.4 as they are related to '06a792b7cc2db33ffce7244c044a9c05afbb6116' Merged bd56d279b612f92d2d1d25f92d32fe7f42a455ca Merged 1ac6e30dd0d9c23d4926860f04a0067ba0d416a9 Resolve references to "this" the same way as normal variables PPC: Resolve references to "this" the same way as normal variables BUG=v8:2700 LOG=N R=machenbach@chromium.org, rossberg@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -138 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +44 lines, -11 lines 0 comments Download
M src/contexts.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/parser.cc View 6 chunks +14 lines, -9 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +17 lines, -3 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/scopes.h View 3 chunks +20 lines, -3 lines 0 comments Download
M src/scopes.cc View 6 chunks +42 lines, -30 lines 0 comments Download
M src/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-scopes.js View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/arrow-functions-this.js View 1 chunk +81 lines, -0 lines 0 comments Download
M test/mjsunit/testcfg.py View 2 chunks +2 lines, -1 line 0 comments Download
A + test/mjsunit/this-dynamic-lookup.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Hablich
5 years, 7 months ago (2015-05-13 11:34:43 UTC) #1
Michael Hablich
PTAL
5 years, 7 months ago (2015-05-13 11:35:20 UTC) #2
rossberg
lgtm
5 years, 7 months ago (2015-05-13 12:25:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135393002/1
5 years, 7 months ago (2015-05-13 12:26:57 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 7 months ago (2015-05-13 12:26:59 UTC) #7
Michael Achenbach
This must be landed by the merge script that created this cl.
5 years, 7 months ago (2015-05-13 14:19:24 UTC) #8
Michael Hablich
On 2015/05/13 14:19:24, Michael Achenbach wrote: > This must be landed by the merge script ...
5 years, 7 months ago (2015-05-13 14:24:40 UTC) #9
Michael Achenbach
5 years, 7 months ago (2015-05-15 08:42:40 UTC) #10
Can this be closed?

Powered by Google App Engine
This is Rietveld 408576698