Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1135373003: Revert of Move SecurityLevel into a class of its own (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tfarina, James Su, lgarron, Ryan Sleevi, jdduke (slow), pasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move SecurityLevel into a class of its own (patchset #19 id:420001 of https://codereview.chromium.org/1123943002/) Reason for revert: Android Tests dbg bot is failing: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg) Failure example: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27901 Original issue's description: > Move SecurityLevel into a class of its own > > This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel| > enum into a class of their own: |ConnectionSecurityHelper| in > //chrome/browser/ssl (since it is applying Chrome-specific security > policy to determine the security level of a page). > > Later, we will use the new |ConnectionSecurityHelper| class to compute a > security level for a page to send to the DevTools Security > panel. Specifically, we need to be able to calculate the security level > for a given page, not just the WebContents for the active tab. > > BUG=484392 > > Committed: https://crrev.com/ca7c0a3374c21ab10c821f4f3a890afc79182acf > Cr-Commit-Position: refs/heads/master@{#329591} > > Committed: https://crrev.com/f50c9b4834e151aa6b5538545a503614cb74f5f9 > Cr-Commit-Position: refs/heads/master@{#329724} TBR=felt@chromium.org,pkasting@chromium.org,rsleevi@chromium.org,bauerb@chromium.org,sky@chromium.org,tedchoc@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484392 Committed: https://crrev.com/39722bb693112be3d91c729246c0ade351e7e900 Cr-Commit-Position: refs/heads/master@{#329827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -421 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 6 chunks +15 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java View 3 chunks +9 lines, -10 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ssl/ConnectionSecurityHelper.java View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/TabTest.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 10 chunks +28 lines, -19 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/ssl/connection_security_helper.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/ssl/connection_security_helper.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/ssl/connection_security_helper_android.h View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/ssl/connection_security_helper_android.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.h View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.h View 4 chunks +33 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 6 chunks +127 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 7 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sergeyv
Created Revert of Move SecurityLevel into a class of its own
5 years, 7 months ago (2015-05-14 10:54:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135373003/1
5 years, 7 months ago (2015-05-14 10:54:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 10:55:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/39722bb693112be3d91c729246c0ade351e7e900 Cr-Commit-Position: refs/heads/master@{#329827}
5 years, 7 months ago (2015-05-14 10:56:19 UTC) #4
sergeyv
5 years, 7 months ago (2015-05-14 11:58:06 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1124383007/ by sergeyv@chromium.org.

The reason for reverting is: Reland initial patch. There is a fix for
SecurityLevelTest:

https://codereview.chromium.org/1135073003.

Powered by Google App Engine
This is Rietveld 408576698