Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1135073003: Fix TabTest#testTabSecurityLevel that was failing (Closed)

Created:
5 years, 7 months ago by dgn
Modified:
5 years, 7 months ago
Reviewers:
Miguel Garcia, estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TabTest#testTabSecurityLevel that was failing BUG=487989 Committed: https://crrev.com/bb993b26784b99689dde46c8694e0d4821da24fb Cr-Commit-Position: refs/heads/master@{#329835}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/TabTest.java View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
dgn
PTAL
5 years, 7 months ago (2015-05-14 10:34:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135073003/1
5 years, 7 months ago (2015-05-14 10:34:20 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-14 10:34:23 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135073003/1
5 years, 7 months ago (2015-05-14 10:36:08 UTC) #8
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-14 10:36:12 UTC) #10
Miguel Garcia
lgtm
5 years, 7 months ago (2015-05-14 11:04:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135073003/1
5 years, 7 months ago (2015-05-14 11:05:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63583)
5 years, 7 months ago (2015-05-14 11:10:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135073003/20001
5 years, 7 months ago (2015-05-14 12:06:22 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 12:27:16 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bb993b26784b99689dde46c8694e0d4821da24fb Cr-Commit-Position: refs/heads/master@{#329835}
5 years, 7 months ago (2015-05-14 12:28:46 UTC) #20
estark
5 years, 7 months ago (2015-05-14 13:37:33 UTC) #21
Message was sent while issue was closed.
Thank you so much for fixing this!

Powered by Google App Engine
This is Rietveld 408576698