Issue 1135283005: Sky: Add a CustomDart attribute to the IDL compiler, and use that with Canvas

Issue 1135283005: Sky: Add a CustomDart attribute to the IDL compiler, and use that with Canvas (Closed)

Created:
5 years, 7 months ago by Matt Perry

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Sky: Add a CustomDart attribute to the IDL compiler, and use that with Canvas to provide a better Dart API. When the attribute is present on an IDL interface, the generate Dart code will be a private interface that can extended by custom dart code. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cdb1efcbc1e30aaece16d6db19cfe0553f42f197

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -15 lines)			Patch
M	sky/engine/bindings/IDLExtendedAttributes.txt	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/engine/bindings/scripts/code_generator_dart.py	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download
M	sky/engine/bindings/scripts/dart_compiler.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/bindings/scripts/templates/interface_dart.template	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	sky/engine/core/painting/Canvas.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	sky/engine/core/painting/Canvas.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	sky/engine/core/painting/Canvas.dart	View		1 chunk	+40 lines, -0 lines	0 comments	Download
M	sky/engine/core/painting/Canvas.idl	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/raw/painting.sky	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

eseidel

lgtm This looks great. I expect we'll create more sophisticated Rect, Point, Size classes in ...

5 years, 7 months ago (2015-05-19 17:37:45 UTC) #3

Matt Perry

On 2015/05/19 17:37:45, eseidel wrote: > lgtm > > This looks great. > > I ...

5 years, 7 months ago (2015-05-19 17:45:31 UTC) #4

Matt Perry

5 years, 7 months ago (2015-05-19 17:59:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
cdb1efcbc1e30aaece16d6db19cfe0553f42f197 (presubmit successful).