tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py - Issue 1135173007: Kill page_test.NavigateToPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 1135173007: Kill page_test.NavigateToPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KillNavigateToPage

Patch Set: Address sclittle's comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

index fba1d99bfcfbc76684104e6ef6ae5db7cf97576b..6e6af1db7161ea0f1e46368bc941f8062777afb2 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

@@ -113,10 +113,6 @@ class ChromeProxySafebrowsingOn(ChromeProxyValidation):

super(ChromeProxySafebrowsingOn, self).__init__(

metrics=metrics.ChromeProxyMetric())

- def WillNavigateToPage(self, page, tab):

- super(ChromeProxySafebrowsingOn, self).WillNavigateToPage(page, tab)

- self._expect_timeout = True

def AddResults(self, tab, results):

self._metrics.AddResultsForSafebrowsingOn(tab, results)