tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py - Issue 1135173007: Kill page_test.NavigateToPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

Issue 1135173007: Kill page_test.NavigateToPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KillNavigateToPage

Patch Set: Address sclittle's comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py b/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

index e1fcb0a10c15af08dc15ed78b8fad1db6bdc42cf..df51b4f48666f73e5c34eb9e34744503a01ff48d 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

@@ -89,7 +89,12 @@ class ChromeProxyBlockOnce(ChromeProxyBenchmark):

class ChromeProxySafeBrowsingOn(ChromeProxyBenchmark):

tag = 'safebrowsing_on'

test = measurements.ChromeProxySafebrowsingOn

- page_set = pagesets.SafebrowsingPageSet

+ # Override CreateUserStorySet so that we can instantiate SafebrowsingPageSet

+ # with a non default param.

+ def CreateUserStorySet(self, options):

+ del options # unused

+ return pagesets.SafebrowsingPageSet(expect_timeout=True)

@classmethod

def Name(cls):