Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1134993005: Skia masters: refuse to merge builds for commits with 'NO_MERGE_BUILDS' (Closed)

Created:
5 years, 7 months ago by borenet
Modified:
5 years, 7 months ago
Reviewers:
rmistry
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Skia masters: refuse to merge builds for commits with 'NO_MERGE_BUILDS' BUG=skia:3584 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M scripts/master/skia/skia_master_utils.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
borenet
5 years, 7 months ago (2015-05-13 12:39:12 UTC) #2
rmistry
LGTM Which usecases do you have in mind?
5 years, 7 months ago (2015-05-13 12:40:34 UTC) #3
rmistry
On 2015/05/13 12:40:34, rmistry wrote: > LGTM > > Which usecases do you have in ...
5 years, 7 months ago (2015-05-13 12:41:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134993005/1
5 years, 7 months ago (2015-05-13 12:52:11 UTC) #6
borenet
On 2015/05/13 12:41:24, rmistry wrote: > On 2015/05/13 12:40:34, rmistry wrote: > > LGTM > ...
5 years, 7 months ago (2015-05-13 12:53:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295242
5 years, 7 months ago (2015-05-13 12:56:34 UTC) #8
borenet
5 years, 7 months ago (2015-05-13 13:01:58 UTC) #9
Message was sent while issue was closed. 
On 2015/05/13 12:41:24, rmistry wrote:
> On 2015/05/13 12:40:34, rmistry wrote:
> > LGTM
> > 
> > Which usecases do you have in mind?
> 
> Also, can you add it here: https://skia.org/dev/contrib/cqkeywords
> It is not really a CQ keyword but its similar to the others.

Uploaded https://codereview.chromium.org/1135313004/

Powered by Google App Engine
This is Rietveld 408576698