Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: scripts/master/skia/skia_master_utils.py

Issue 1134993005: Skia masters: refuse to merge builds for commits with 'NO_MERGE_BUILDS' (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/skia/skia_master_utils.py
diff --git a/scripts/master/skia/skia_master_utils.py b/scripts/master/skia/skia_master_utils.py
index 049853a8a80b8938f89c6698ca4a262d00922f42..3688cdf56303aad209e5a6e55d14533d818b75cc 100644
--- a/scripts/master/skia/skia_master_utils.py
+++ b/scripts/master/skia/skia_master_utils.py
@@ -53,6 +53,8 @@ SCHEDULERS = [
INFRA_PERCOMMIT_SCHEDULER_NAME,
]
+KEYWORD_NO_MERGE_BUILDS = 'NO_MERGE_BUILDS'
+
def CanMergeBuildRequests(req1, req2):
"""Determine whether or not two BuildRequests can be merged.
@@ -93,7 +95,11 @@ def CanMergeBuildRequests(req1, req2):
return False
if not req1.source.changes and req2.source.changes:
return False
- if not (req1.source.changes and req2.source.changes):
+ if req1.source.changes and req2.source.changes:
+ for ch in (req1.source.changes + req2.source.changes):
+ if KEYWORD_NO_MERGE_BUILDS in ch.comments:
+ return False
+ else:
if req1.source.revision != req2.source.revision:
return False
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698