Issue 1134913004: PPC: Fix '[strong] Function arity check should be based on required parameters'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134913004: PPC: Fix '[strong] Function arity check should be based on required parameters' (Closed)

Created:
5 years, 7 months ago by MTBrandyberry

Modified:
5 years, 7 months ago

Reviewers:
michael_dawson, arv (Not doing code reviews), dstence

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

PPC: Fix '[strong] Function arity check should be based on required parameters' lwa cannot encode unaligned displacements. lwz is acceptable here since the shift right will perform the sign-extension on PPC64 for us. R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/f32a3643b570ba6509b1c366f9fe617c2e7a7c68 Cr-Commit-Position: refs/heads/master@{#28517}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ppc/builtins-ppc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134913004/1

5 years, 7 months ago (2015-05-20 12:36:06 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 13:31:07 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f32a3643b570ba6509b1c366f9fe617c2e7a7c68
Cr-Commit-Position: refs/heads/master@{#28517}