Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ppc/builtins-ppc.cc

Issue 1134913004: PPC: Fix '[strong] Function arity check should be based on required parameters' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 1760 matching lines...) Expand 10 before | Expand all | Expand 10 after
1771 __ TestBit(r8, 1771 __ TestBit(r8,
1772 #if V8_TARGET_ARCH_PPC64 1772 #if V8_TARGET_ARCH_PPC64
1773 SharedFunctionInfo::kStrongModeFunction, 1773 SharedFunctionInfo::kStrongModeFunction,
1774 #else 1774 #else
1775 SharedFunctionInfo::kStrongModeFunction + kSmiTagSize, 1775 SharedFunctionInfo::kStrongModeFunction + kSmiTagSize,
1776 #endif 1776 #endif
1777 r0); 1777 r0);
1778 __ beq(&no_strong_error, cr0); 1778 __ beq(&no_strong_error, cr0);
1779 1779
1780 // What we really care about is the required number of arguments. 1780 // What we really care about is the required number of arguments.
1781 __ lwa(r7, FieldMemOperand(r7, SharedFunctionInfo::kLengthOffset)); 1781 __ lwz(r7, FieldMemOperand(r7, SharedFunctionInfo::kLengthOffset));
1782 #if V8_TARGET_ARCH_PPC64 1782 #if V8_TARGET_ARCH_PPC64
1783 // See commment near kLenghtOffset in src/objects.h 1783 // See commment near kLenghtOffset in src/objects.h
1784 __ srawi(r7, r7, kSmiTagSize); 1784 __ srawi(r7, r7, kSmiTagSize);
1785 #else 1785 #else
1786 __ SmiUntag(r7); 1786 __ SmiUntag(r7);
1787 #endif 1787 #endif
1788 __ cmp(r3, r7); 1788 __ cmp(r3, r7);
1789 __ bge(&no_strong_error); 1789 __ bge(&no_strong_error);
1790 1790
1791 { 1791 {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
1863 __ bkpt(0); 1863 __ bkpt(0);
1864 } 1864 }
1865 } 1865 }
1866 1866
1867 1867
1868 #undef __ 1868 #undef __
1869 } 1869 }
1870 } // namespace v8::internal 1870 } // namespace v8::internal
1871 1871
1872 #endif // V8_TARGET_ARCH_PPC 1872 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698