Issue 11348382: Moving AudioElement back to dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348382: Moving AudioElement back to dart:html (Closed)

Created:
8 years ago by blois

Modified:
8 years ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Moving AudioElement back to dart:html Switched to using module or directory names from the IDL to determine the dart: library name. Picked up some other types which should be moved as well. BUG=7124 Committed: https://code.google.com/p/dart/source/detail?r=15707

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -121 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	4 chunks	+26 lines, -28 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+27 lines, -40 lines	0 comments	Download
M	sdk/lib/html/scripts/htmlrenamer.py	View	2 chunks	+7 lines, -8 lines	2 comments	Download
M	sdk/lib/html/scripts/idlnode.py	View	4 chunks	+9 lines, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/impl/impl_AudioContext.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	2 chunks	+2 lines, -20 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	2 chunks	+6 lines, -21 lines	0 comments	Download
M	tests/html/audioelement_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/11348382/diff/1/sdk/lib/html/scripts/htmlrenamer.py File sdk/lib/html/scripts/htmlrenamer.py (left): https://codereview.chromium.org/11348382/diff/1/sdk/lib/html/scripts/htmlrenamer.py#oldcode368 sdk/lib/html/scripts/htmlrenamer.py:368: if idl_type_name.startswith('SVG'): There are still collection cases which do ...

8 years ago (2012-12-04 18:39:39 UTC) #1

sra1

8 years ago (2012-12-04 20:18:48 UTC) #2

lgtm

https://codereview.chromium.org/11348382/diff/1/sdk/lib/html/scripts/htmlrena...
File sdk/lib/html/scripts/htmlrenamer.py (right):

https://codereview.chromium.org/11348382/diff/1/sdk/lib/html/scripts/htmlrena...
sdk/lib/html/scripts/htmlrenamer.py:362: return 'web_audio'
This works so much better.

Expand Messages | Collapse Messages