Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1134833003: Add -pie to chrome on Linux in GN. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add -pie to chrome on Linux in GN. This matches the GYP build. Committed: https://crrev.com/bb11c4eca85b840a75450125d530c50fed5f48e8 Cr-Commit-Position: refs/heads/master@{#329565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 7 months ago (2015-05-12 21:42:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134833003/1
5 years, 7 months ago (2015-05-12 21:42:24 UTC) #4
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-12 21:44:29 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 22:16:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134833003/1
5 years, 7 months ago (2015-05-13 01:48:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 01:53:31 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:54:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb11c4eca85b840a75450125d530c50fed5f48e8
Cr-Commit-Position: refs/heads/master@{#329565}

Powered by Google App Engine
This is Rietveld 408576698