Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: chrome/BUILD.gn

Issue 1134833003: Add -pie to chrome on Linux in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index f25dd9c2b5a27ba68219d75ba05fd14235a6c94a..77a67b16540dd0ada9d85397115c8868fe784b75 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -116,11 +116,9 @@ if (!is_android) {
# Needed for chrome_main.cc initialization of libraries.
configs += [ "//build/config/linux:pangocairo" ]
- # TODO(GYP) ['profiling==0 and linux_disable_pie==0', {
- # 'ldflags': [
- # '-pie',
- # ],
- #}],
+ # GYP has this in a 'profiling==0 and linux_disable_pie==0' condition.
+ # but GN doesn't have either of these flags.
+ ldflags = [ "-pie" ]
if (use_x11) {
configs += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698