Issue 11348291: Analyze Dart scripts in HTML files.

Issue 11348291: Analyze Dart scripts in HTML files. (Closed)

Created:
8 years ago by scheglov

Modified:
8 years ago

Reviewers:
devoncarew, danrubel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Analyze Dart scripts in HTML files. Right now only for adding markers. R=devoncarew@google.com,danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15533

Patch Set 2 : Analyze in builder thread #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+320 lines, -237 lines)			Patch
M	compiler/java/com/google/dart/compiler/UrlLibrarySource.java	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/META-INF/MANIFEST.MF	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java	View		2 chunks	+24 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java	View		3 chunks	+3 lines, -1 line	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlBuildParticipant.java	View	1	1 chunk	+19 lines, -18 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/META-INF/MANIFEST.MF	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/TestAll.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/html/HtmlAnalyzeHelperTest.java	View	1	1 chunk	+144 lines, -0 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/html/TestAll.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/test/AbstractDartCoreTest.java	View		4 chunks	+3 lines, -32 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/AbstractDartTest.java	View		2 chunks	+2 lines, -178 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danrubel

LGTM with a couple suggestions. https://codereview.chromium.org/11348291/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java (right): https://codereview.chromium.org/11348291/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java#newcode110 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java:110: server.analyze(scriptFile); Better would be ...

8 years ago (2012-11-29 14:43:41 UTC) #2

scheglov

PTAL https://codereview.chromium.org/11348291/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java (right): https://codereview.chromium.org/11348291/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java#newcode110 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java:110: server.analyze(scriptFile); On 2012/11/29 14:43:42, danrubel wrote: > Better ...

8 years ago (2012-11-29 17:52:46 UTC) #3

lgtm

Expand Messages | Collapse Messages