editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java - Issue 11348291: Analyze Dart scripts in HTML files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

Issue 11348291: Analyze Dart scripts in HTML files. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Analyze in builder thread Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlAnalyzeHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

index e98b6a80986d2ebf239a4a5f33f0ddea516cdd78..f5d7d1ea8fead8107bb8961a12fc472d2fe0b4f5 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java

@@ -21,6 +21,7 @@ import com.google.dart.tools.core.analysis.AnalysisError;

import com.google.dart.tools.core.analysis.AnalysisEvent;

import com.google.dart.tools.core.analysis.AnalysisListener;

import com.google.dart.tools.core.analysis.AnalysisServer;

+import com.google.dart.tools.core.html.HtmlAnalyzeHelper;

import com.google.dart.tools.core.internal.util.ResourceUtil;

import org.eclipse.core.resources.IMarker;

@@ -58,6 +59,7 @@ class AnalysisMarkerManager implements AnalysisListener {

if (file == null || error == null) {

return;

}

+ file = HtmlAnalyzeHelper.getSourceHtmlFile(file);

IResource res = ResourceUtil.getResource(file);

if (res == null || !res.exists() || !DartCore.isAnalyzed(res)) {

return;

@@ -91,11 +93,11 @@ class AnalysisMarkerManager implements AnalysisListener {

try {

IMarker marker = res.createMarker(DartCore.DART_PROBLEM_MARKER_TYPE);

marker.setAttribute(IMarker.SEVERITY, severity);

- marker.setAttribute(IMarker.MESSAGE, errMsg);

marker.setAttribute(IMarker.CHAR_START, offset);

marker.setAttribute(IMarker.CHAR_END, offset + length);

marker.setAttribute(IMarker.LINE_NUMBER, lineNumber);

marker.setAttribute("errorCode", errorCodeString);

+ marker.setAttribute(IMarker.MESSAGE, errMsg);

} catch (CoreException e) {

DartCore.logError("Failed to create marker for " + res + "\n at " + offset + " message: "

+ errMsg, e);