[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/common/autofill_messages.h

Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index b60c868fbf00cb59a43da3bd64c7c386d6635ef2..692083bd6818c36d0530ce9697146f87304091da 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -134,9 +134,12 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
 IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
                     content::PasswordForm /* form checked */)
 
-// Sent when interactive autocomplete finishes.
-IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteFinished,
-                    WebKit::WebFormElement::AutocompleteResult /* result */)
+// Sent when interactive autocomplete succeeds. Changes the original form.

[Ilya Sherman, 2012/11/28 06:16:39]

nit: I'm not sure I follow what "Changes the original form" means...

[Dan Beam, 2012/11/28 19:59:10]

Done. (how about now?)

[Ilya Sherman, 2012/11/29 00:08:59]

This is clearer, thanks.  It's still a little weird to say that the IPC message
fills a form though -- the IPC message just passes data to the renderer. 
Perhaps phrase the second sentence as "Tells the renderer to Autofill the form
that requested autocomplete with the |form_data| values input by the user."?

[Dan Beam, 2012/11/29 00:51:13]

Done.

+IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteSuccess,
+                    FormData /* form_data */)
+
+// Sent when interactive autocomplete fails for any number of reasons.
+IPC_MESSAGE_ROUTED0(AutofillMsg_RequestAutocompleteError);

[Ilya Sherman, 2012/11/28 06:16:39]

nit: The comment makes me want to see the failure reason passed back as part of
this IPC.  How come it isn't?

[Dan Beam, 2012/11/28 19:59:10]

We currently don't have a failure reason enum or anything like that.  Do you
want me to make?  It'll be useful if a) we end up passing this the whole way
back to the DOM, b) for testing.

[Ilya Sherman, 2012/11/29 00:08:59]

IMO this would be clearer either if you pass an enum value; or if there's no
need for one yet, drop the "for any number of reasons" phrase from the comment.

[Dan Beam, 2012/11/29 00:51:13]

This is only failing for 1 reason right now, so just updated the doc about this.

 
 // Autofill messages sent from the renderer to the browser.