[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/common/autofill_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 
 #include "base/time.h"
 #include "chrome/common/common_param_traits_macros.h"
@@ skipping 116 matching lines @@
 
 // Tells the renderer that the password field has accept the suggestion.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
                     string16 /* username value*/)
 
 // Tells the renderer that this password form is not blacklisted.  A form can
 // be blacklisted if a user chooses "never save passwords for this site".
 IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
                     content::PasswordForm /* form checked */)
 
-// Sent when interactive autocomplete finishes.
-IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteFinished,
-                    WebKit::WebFormElement::AutocompleteResult /* result */)
+// Sent when interactive autocomplete succeeds. Changes the original form.

[Ilya Sherman, 2012/11/28 06:16:39]

nit: I'm not sure I follow what "Changes the original form" means...

[Dan Beam, 2012/11/28 19:59:10]

Done. (how about now?)

[Ilya Sherman, 2012/11/29 00:08:59]

This is clearer, thanks.  It's still a little weird to say that the IPC message
fills a form though -- the IPC message just passes data to the renderer. 
Perhaps phrase the second sentence as "Tells the renderer to Autofill the form
that requested autocomplete with the |form_data| values input by the user."?

[Dan Beam, 2012/11/29 00:51:13]

Done.

+IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteSuccess,
+                    FormData /* form_data */)
+
+// Sent when interactive autocomplete fails for any number of reasons.
+IPC_MESSAGE_ROUTED0(AutofillMsg_RequestAutocompleteError);

[Ilya Sherman, 2012/11/28 06:16:39]

nit: The comment makes me want to see the failure reason passed back as part of
this IPC.  How come it isn't?

[Dan Beam, 2012/11/28 19:59:10]

We currently don't have a failure reason enum or anything like that.  Do you
want me to make?  It'll be useful if a) we end up passing this the whole way
back to the DOM, b) for testing.

[Ilya Sherman, 2012/11/29 00:08:59]

IMO this would be clearer either if you pass an enum value; or if there's no
need for one yet, drop the "for any number of reasons" phrase from the comment.

[Dan Beam, 2012/11/29 00:51:13]

This is only failing for 1 reason right now, so just updated the doc about this.

 
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
 // filling/submitting by the AutofillManager.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_FormsSeen,
                     std::vector<FormData> /* forms */,
                     base::TimeTicks /* timestamp */)
 
 // Notification that password forms have been seen that are candidates for
@@ skipping 82 matching lines @@
                     FormFieldData /* the form field */,
                     gfx::Rect /* input field bounds, window-relative */,
                     std::vector<string16> /* suggestions */)
 
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED4(AutofillHostMsg_SetDataList,
                     std::vector<string16> /* values */,
                     std::vector<string16> /* labels */,
                     std::vector<string16> /* icons */,
                     std::vector<int> /* unique ids */)