Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: runtime/lib/integers.cc

Issue 11348259: Canonicalize all integer constants taht we create by parsing a string. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/integers.cc
===================================================================
--- runtime/lib/integers.cc (revision 15418)
+++ runtime/lib/integers.cc (working copy)
@@ -195,11 +195,11 @@
&is_positive,
&int_string)) {
if (is_positive) {
- return Integer::New(*int_string);
+ return Integer::NewCanonical(*int_string);
}
String& temp = String::Handle();
temp = String::Concat(String::Handle(Symbols::New("-")), *int_string);
- return Integer::New(temp);
+ return Integer::NewCanonical(temp);
srdjan 2012/11/27 23:32:07 ditto.
siva 2012/11/28 00:22:56 Done.
}
GrowableArray<const Object*> args;

Powered by Google App Engine
This is Rietveld 408576698