Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: runtime/lib/double.cc

Issue 11348259: Canonicalize all integer constants taht we create by parsing a string. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/double.cc
===================================================================
--- runtime/lib/double.cc (revision 15418)
+++ runtime/lib/double.cc (working copy)
@@ -221,18 +221,18 @@
if (!is_positive) {
double_value = -double_value;
}
- return Double::New(double_value);
+ return Double::NewCanonical(double_value);
srdjan 2012/11/27 23:32:07 Do not canonicalize om this native, as it is calle
siva 2012/11/28 00:22:56 Done.
}
if (Scanner::IsValidLiteral(tokens,
Token::kINTEGER,
&is_positive,
&number_string)) {
- Integer& res = Integer::Handle(Integer::New(*number_string));
+ Integer& res = Integer::Handle(Integer::NewCanonical(*number_string));
if (is_positive) {
- return Double::New(res.AsDoubleValue());
+ return Double::NewCanonical(res.AsDoubleValue());
}
- return Double::New(-res.AsDoubleValue());
+ return Double::NewCanonical(-res.AsDoubleValue());
}
// Infinity and nan.
@@ -241,13 +241,13 @@
&is_positive,
&number_string)) {
if (number_string->Equals("NaN")) {
- return Double::New(NAN);
+ return Double::NewCanonical(NAN);
}
if (number_string->Equals("Infinity")) {
if (is_positive) {
- return Double::New(INFINITY);
+ return Double::NewCanonical(INFINITY);
}
- return Double::New(-INFINITY);
+ return Double::NewCanonical(-INFINITY);
}
}
« no previous file with comments | « no previous file | runtime/lib/integers.cc » ('j') | runtime/lib/integers.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698