tools/telemetry/telemetry/desktop_browser_backend.py - Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/desktop_browser_backend.py

Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/functional/webpagereplay.py ('K') | « tools/telemetry/telemetry/cros_interface_unittest.py ('k') | tools/telemetry/telemetry/temporary_http_server.py » ('j') | tools/telemetry/telemetry/wpr_server.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/desktop_browser_backend.py b/tools/telemetry/telemetry/desktop_browser_backend.py

index 42cde6f412b436c0ba72d948f228ad281fcfefbd..dea377ad4dbcc711e741952562e816859a44e00d 100644

--- a/tools/telemetry/telemetry/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/desktop_browser_backend.py

@@ -99,7 +99,7 @@ class DesktopBrowserBackend(browser_backend.BrowserBackend):

class DoNothingForwarder(object):

def __init__(self, *port_pairs):

- self._host_port = port_pairs[0][0]

+ self._host_port = port_pairs[0][0] or port_pairs[0][1]

@property

def url(self):