tools/telemetry/telemetry/cros_interface_unittest.py - Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/cros_interface_unittest.py

Issue 11348217: [telemetry] Removing flake in wpr_server.py caused by static port assignment from chrome/test/funct… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/functional/webpagereplay.py ('K') | « tools/telemetry/telemetry/cros_interface.py ('k') | tools/telemetry/telemetry/desktop_browser_backend.py » ('j') | tools/telemetry/telemetry/wpr_server.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/cros_interface_unittest.py

diff --git a/tools/telemetry/telemetry/cros_interface_unittest.py b/tools/telemetry/telemetry/cros_interface_unittest.py

index 4609b651bc8c97557768fef71c632e82b54ca653..2ba47c1346ea4957801a717674876a8c5c32eefd 100644

--- a/tools/telemetry/telemetry/cros_interface_unittest.py

+++ b/tools/telemetry/telemetry/cros_interface_unittest.py

@@ -146,3 +146,17 @@ class CrOSInterfaceTest(unittest.TestCase):

# Device should no longer be able to connect to remote_port since it is no

# longer in use.

self.assertFalse(cri.IsHTTPServerRunningOnPort(remote_port))

+ @run_tests.RequiresBrowserOfType('cros-chrome')

+ def testGetRemotePortReservedPorts(self):

+ remote = options_for_unittests.Get().cros_remote

+ cri = cros_interface.CrOSInterface(

+ remote,

+ options_for_unittests.Get().cros_ssh_identity)

+ # Should return 2 separate ports even though the first one isn't technically

+ # being used yet.

+ remote_port_1 = cri.GetRemotePort()

+ remote_port_2 = cri.GetRemotePort()

+ self.assertTrue(remote_port_1 != remote_port_2)