Add versioning to PluginFinder metadata.

chrome/browser/web_resource/plugins_resource_service.cc

Index: chrome/browser/web_resource/plugins_resource_service.cc
diff --git a/chrome/browser/web_resource/plugins_resource_service.cc b/chrome/browser/web_resource/plugins_resource_service.cc
index 77777d8bae3887d9cd0da818e1cde97a5c7a2865..695c88fe7dfb4982875adfcc9b036c8820c1f6f7 100644
--- a/chrome/browser/web_resource/plugins_resource_service.cc
+++ b/chrome/browser/web_resource/plugins_resource_service.cc
@@ -61,6 +61,14 @@ PluginsResourceService::PluginsResourceService(PrefService* local_state)
                          GetCacheUpdateDelay()) {
 }
 
+void PluginsResourceService::Init() {
+  const base::DictionaryValue* metadata =

[cevans, 2013/02/05 21:06:52]

Nit: hold on to it with const ref not ptr, if it cannot be NULL?

[Bernhard Bauer, 2013/02/06 20:08:24]

Hm. The interface returns a const ptr. What's the advantage in using a const
ref? It doesn't actually verify that it's not NULL, AFAIK.

+      prefs_->GetDictionary(prefs::kPluginsMetadata);
+  PluginFinder::GetInstance()->ReinitializePlugins(
+      make_scoped_ptr(metadata->DeepCopy()));

[cevans, 2013/02/05 21:06:52]

If however, metadata _could_ be NULL, you have a crash.

[Bernhard Bauer, 2013/02/06 20:08:24]

It can't; GetDictionary() returns an empty dictionary by default.

+  StartAfterDelay();
+}
+
 PluginsResourceService::~PluginsResourceService() {
 }
 
@@ -73,5 +81,6 @@ void PluginsResourceService::RegisterPrefs(PrefServiceSimple* local_state) {
 
 void PluginsResourceService::Unpack(const DictionaryValue& parsed_json) {
   prefs_->Set(prefs::kPluginsMetadata, parsed_json);
-  PluginFinder::GetInstance()->ReinitializePlugins(parsed_json);
+  PluginFinder::GetInstance()->ReinitializePlugins(
+      make_scoped_ptr(parsed_json.DeepCopy()));
 }