Add versioning to PluginFinder metadata.

chrome/browser/web_resource/plugins_resource_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/plugins_resource_service.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/plugins/plugin_finder.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 43 matching lines @@
 
 PluginsResourceService::PluginsResourceService(PrefService* local_state)
     : WebResourceService(local_state,
                          GetPluginsServerURL(),
                          false,
                          prefs::kPluginsResourceCacheUpdate,
                          kStartResourceFetchDelayMs,
                          GetCacheUpdateDelay()) {
 }
 
+void PluginsResourceService::Init() {
+  const base::DictionaryValue* metadata =

[cevans, 2013/02/05 21:06:52]

Nit: hold on to it with const ref not ptr, if it cannot be NULL?

[Bernhard Bauer, 2013/02/06 20:08:24]

Hm. The interface returns a const ptr. What's the advantage in using a const
ref? It doesn't actually verify that it's not NULL, AFAIK.

+      prefs_->GetDictionary(prefs::kPluginsMetadata);
+  PluginFinder::GetInstance()->ReinitializePlugins(
+      make_scoped_ptr(metadata->DeepCopy()));

[cevans, 2013/02/05 21:06:52]

If however, metadata _could_ be NULL, you have a crash.

[Bernhard Bauer, 2013/02/06 20:08:24]

It can't; GetDictionary() returns an empty dictionary by default.

+  StartAfterDelay();
+}
+
 PluginsResourceService::~PluginsResourceService() {
 }
 
 // static
 void PluginsResourceService::RegisterPrefs(PrefServiceSimple* local_state) {
   local_state->RegisterDictionaryPref(
       prefs::kPluginsMetadata, new base::DictionaryValue());
   local_state->RegisterStringPref(prefs::kPluginsResourceCacheUpdate, "0");
 }
 
 void PluginsResourceService::Unpack(const DictionaryValue& parsed_json) {
   prefs_->Set(prefs::kPluginsMetadata, parsed_json);
-  PluginFinder::GetInstance()->ReinitializePlugins(parsed_json);
+  PluginFinder::GetInstance()->ReinitializePlugins(
+      make_scoped_ptr(parsed_json.DeepCopy()));
 }