Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5706)

Unified Diff: chrome/browser/plugins/plugin_finder_unittest.cc

Issue 11348046: Add versioning to PluginFinder metadata. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: divx Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_finder_unittest.cc
diff --git a/chrome/browser/plugins/plugin_finder_unittest.cc b/chrome/browser/plugins/plugin_finder_unittest.cc
index fc60576f3bcb72dc93f8e7285ad3c1d6d89697ce..33535302d0e253210cbec312ac9ad71967ff7a3c 100644
--- a/chrome/browser/plugins/plugin_finder_unittest.cc
+++ b/chrome/browser/plugins/plugin_finder_unittest.cc
@@ -10,11 +10,17 @@
#include "webkit/plugins/npapi/plugin_list.h"
using base::DictionaryValue;
+using base::ListValue;
using webkit::npapi::PluginList;
TEST(PluginFinderTest, JsonSyntax) {
- scoped_ptr<DictionaryValue> plugin_list(PluginFinder::LoadPluginList());
+ scoped_ptr<DictionaryValue> plugin_list(
+ PluginFinder::LoadBuiltInPluginList());
ASSERT_TRUE(plugin_list.get());
+ base::Value* version = NULL;
+ if (plugin_list->Remove("x-version", &version))
Chris Evans 2013/02/08 19:25:23 Nit: Now that we are versioning our files, I think
Bernhard Bauer 2013/02/11 09:58:19 Done.
+ EXPECT_EQ(base::Value::TYPE_INTEGER, version->GetType());
+
for (DictionaryValue::Iterator plugin_it(*plugin_list);
plugin_it.HasNext(); plugin_it.Advance()) {
const DictionaryValue* plugin = NULL;

Powered by Google App Engine
This is Rietveld 408576698