Add versioning to PluginFinder metadata.

chrome/browser/plugins/plugin_finder_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_finder.h"
 
 #include "base/values.h"
 #include "chrome/browser/plugins/plugin_metadata.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/plugins/npapi/plugin_list.h"
 
 using base::DictionaryValue;
+using base::ListValue;
 using webkit::npapi::PluginList;
 
 TEST(PluginFinderTest, JsonSyntax) {
-  scoped_ptr<DictionaryValue> plugin_list(PluginFinder::LoadPluginList());
+  scoped_ptr<DictionaryValue> plugin_list(
+    PluginFinder::LoadBuiltInPluginList());
   ASSERT_TRUE(plugin_list.get());
+  base::Value* version = NULL;
+  if (plugin_list->Remove("x-version", &version))

[Chris Evans, 2013/02/08 19:25:23]

Nit: Now that we are versioning our files, I think it's ok to EXPECT that the
version is always there.

[Bernhard Bauer, 2013/02/11 09:58:19]

Done.

+    EXPECT_EQ(base::Value::TYPE_INTEGER, version->GetType());
+
   for (DictionaryValue::Iterator plugin_it(*plugin_list);
        plugin_it.HasNext(); plugin_it.Advance()) {
     const DictionaryValue* plugin = NULL;
     ASSERT_TRUE(plugin_it.value().GetAsDictionary(&plugin));
     std::string dummy_str;
     bool dummy_bool;
     if (plugin->HasKey("lang"))
       EXPECT_TRUE(plugin->GetString("lang", &dummy_str));
     if (plugin->HasKey("url"))
       EXPECT_TRUE(plugin->GetString("url", &dummy_str));
@@ skipping 31 matching lines @@
       EXPECT_TRUE(version_dict->GetString("version", &dummy_str));
       std::string status_str;
       EXPECT_TRUE(version_dict->GetString("status", &status_str));
       PluginMetadata::SecurityStatus status =
           PluginMetadata::SECURITY_STATUS_UP_TO_DATE;
       EXPECT_TRUE(PluginMetadata::ParseSecurityStatus(status_str, &status))
           << "Invalid security status \"" << status_str << "\"";
     }
   }
 }