Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: gin/BUILD.gn

Issue 1134753011: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/BUILD.gn ('k') | mojo/mojo_application_package.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/BUILD.gn
diff --git a/gin/BUILD.gn b/gin/BUILD.gn
index ab768ffdb7702f804ae085deda7cfb0a854e8191..793ee3d8fa7999931b584ab5a97708fc9c2d880e 100644
--- a/gin/BUILD.gn
+++ b/gin/BUILD.gn
@@ -76,10 +76,8 @@ component("gin") {
"//base/third_party/dynamic_annotations",
]
if (v8_use_external_startup_data && is_win) {
- deps += [
- ":gin_v8_snapshot_fingerprint",
- "//crypto:crypto",
- ]
+ public_deps += [ ":gin_v8_snapshot_fingerprint" ]
+ deps += [ "//crypto:crypto" ]
sources += [ "$target_gen_dir/v8_snapshot_fingerprint.cc" ]
defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ]
}
@@ -108,6 +106,10 @@ if (v8_use_external_startup_data) {
outputs = [
output_file,
]
+
+ deps = [
+ "//v8",
+ ]
}
}
« no previous file with comments | « extensions/BUILD.gn ('k') | mojo/mojo_application_package.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698