Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Side by Side Diff: gin/BUILD.gn

Issue 1134753011: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/BUILD.gn ('k') | mojo/mojo_application_package.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/module_args/v8.gni") 5 import("//build/module_args/v8.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 component("gin") { 8 component("gin") {
9 sources = [ 9 sources = [
10 "arguments.cc", 10 "arguments.cc",
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 defines = [ "GIN_IMPLEMENTATION" ] 69 defines = [ "GIN_IMPLEMENTATION" ]
70 70
71 public_deps = [ 71 public_deps = [
72 "//base", 72 "//base",
73 "//v8", 73 "//v8",
74 ] 74 ]
75 deps = [ 75 deps = [
76 "//base/third_party/dynamic_annotations", 76 "//base/third_party/dynamic_annotations",
77 ] 77 ]
78 if (v8_use_external_startup_data && is_win) { 78 if (v8_use_external_startup_data && is_win) {
79 deps += [ 79 public_deps += [ ":gin_v8_snapshot_fingerprint" ]
80 ":gin_v8_snapshot_fingerprint", 80 deps += [ "//crypto:crypto" ]
81 "//crypto:crypto",
82 ]
83 sources += [ "$target_gen_dir/v8_snapshot_fingerprint.cc" ] 81 sources += [ "$target_gen_dir/v8_snapshot_fingerprint.cc" ]
84 defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ] 82 defines += [ "V8_VERIFY_EXTERNAL_STARTUP_DATA" ]
85 } 83 }
86 } 84 }
87 85
88 if (v8_use_external_startup_data) { 86 if (v8_use_external_startup_data) {
89 action("gin_v8_snapshot_fingerprint") { 87 action("gin_v8_snapshot_fingerprint") {
90 script = "//gin/fingerprint/fingerprint_v8_snapshot.py" 88 script = "//gin/fingerprint/fingerprint_v8_snapshot.py"
91 89
92 snapshot_file = "$root_build_dir/snapshot_blob.bin" 90 snapshot_file = "$root_build_dir/snapshot_blob.bin"
93 natives_file = "$root_build_dir/natives_blob.bin" 91 natives_file = "$root_build_dir/natives_blob.bin"
94 output_file = "$target_gen_dir/v8_snapshot_fingerprint.cc" 92 output_file = "$target_gen_dir/v8_snapshot_fingerprint.cc"
95 93
96 args = [ 94 args = [
97 "--snapshot_file", 95 "--snapshot_file",
98 rebase_path(snapshot_file, root_build_dir), 96 rebase_path(snapshot_file, root_build_dir),
99 "--natives_file", 97 "--natives_file",
100 rebase_path(natives_file, root_build_dir), 98 rebase_path(natives_file, root_build_dir),
101 "--output_file", 99 "--output_file",
102 rebase_path(output_file, root_build_dir), 100 rebase_path(output_file, root_build_dir),
103 ] 101 ]
104 inputs = [ 102 inputs = [
105 snapshot_file, 103 snapshot_file,
106 natives_file, 104 natives_file,
107 ] 105 ]
108 outputs = [ 106 outputs = [
109 output_file, 107 output_file,
110 ] 108 ]
109
110 deps = [
111 "//v8",
112 ]
111 } 113 }
112 } 114 }
113 115
114 executable("gin_shell") { 116 executable("gin_shell") {
115 sources = [ 117 sources = [
116 "shell/gin_main.cc", 118 "shell/gin_main.cc",
117 ] 119 ]
118 120
119 deps = [ 121 deps = [
120 ":gin", 122 ":gin",
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 "test/run_js_tests.cc", 163 "test/run_js_tests.cc",
162 "wrappable_unittest.cc", 164 "wrappable_unittest.cc",
163 ] 165 ]
164 166
165 deps = [ 167 deps = [
166 ":gin_test", 168 ":gin_test",
167 "//base/test:test_support", 169 "//base/test:test_support",
168 "//v8", 170 "//v8",
169 ] 171 ]
170 } 172 }
OLDNEW
« no previous file with comments | « extensions/BUILD.gn ('k') | mojo/mojo_application_package.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698