build/secondary/tools/grit/grit_rule.gni - Issue 1134753011: Fix missing GN dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 1134753011: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/tools/grit/grit_rule.gni

diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni

index 35bbed32734815ec67ecad23ccb411f5cd661a49..3f22123993acbdeb3d3b9af06ff3b425c300b12d 100644

--- a/build/secondary/tools/grit/grit_rule.gni

+++ b/build/secondary/tools/grit/grit_rule.gni

@@ -445,9 +445,11 @@ template("grit") {

# depend on us.

sources = grit_outputs

- # Deps set on the template invocation will go on the grit script running

- # target rather than this library.

- deps = [

+ # Deps set on the template invocation will go on the action that runs

+ # grit above rather than this library. This target needs to depend on the

+ # action publicly so other scripts can take the outputs from the grit

+ # script as inputs.

+ public_deps = [

":$grit_custom_target",

]

public_configs = [ ":$grit_config" ]

« no previous file with comments | « build/json_schema_api.gni ('k') | chrome/BUILD.gn » ('j') | no next file with comments »