Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5868)

Unified Diff: build/json_schema_api.gni

Issue 1134753011: Fix missing GN dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/json_schema_api.gni
diff --git a/build/json_schema_api.gni b/build/json_schema_api.gni
index aa6365b948ee505484650961634ee9aee2c35055..e1c2d33409d52ad4d92f6e233e3ce31f84789574 100644
--- a/build/json_schema_api.gni
+++ b/build/json_schema_api.gni
@@ -154,7 +154,9 @@ template("json_schema_api") {
assert(defined(invoker.impl_dir),
"\"impl_dir\" must be defined for the $target_name template.")
- impl_dir = invoker.impl_dir
+
+ # Child directory inside the generated file tree.
+ gen_child_dir = rebase_path(invoker.impl_dir, "//")
bundle_generator_registration_name =
target_name + "_bundle_generator_registration"
@@ -162,15 +164,15 @@ template("json_schema_api") {
script = compiler_script
inputs = compiler_sources + invoker.sources + uncompiled_sources
outputs = [
- "$root_gen_dir/$impl_dir/generated_api_registration.cc",
- "$root_gen_dir/$impl_dir/generated_api_registration.h",
+ "$root_gen_dir/$gen_child_dir/generated_api_registration.cc",
+ "$root_gen_dir/$gen_child_dir/generated_api_registration.h",
]
args = [
"--root=" + rebase_path("//", root_build_dir),
"--destdir=" + rebase_path(root_gen_dir, root_build_dir),
"--namespace=$root_namespace",
"--generator=cpp-bundle-registration",
- "--impl-dir=" + rebase_path(impl_dir, "//"),
+ "--impl-dir=$gen_child_dir",
"--include-rules=$schema_include_rules",
] + rebase_path(invoker.sources, root_build_dir) +
rebase_path(uncompiled_sources, root_build_dir)
« no previous file with comments | « no previous file | build/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698