Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1136643006: Fix cc unit tests that depend on verify_property_trees=true (Closed)

Created:
5 years, 7 months ago by enne (OOO)
Modified:
5 years, 7 months ago
Reviewers:
Ian Vollick, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cc unit tests that depend on verify_property_trees=true A number of cc unit tests have started checking property tree output, primarily visible_rect_from_property_trees but also needs_rebuild on the trees. Because of this, these tests now depend on running the property tree code, so setting verify_property_trees=false forces these tests to run only CDP code which causes them to fail. Therefore, convert these specific tests to use property tree updates directly. This also requires a PrecalculateMetaInformation function for LayerImpl, as LayerTreeHostCommonTest.SkippingSubtreeImpl touched LayerImpl properties that could only theoretically be changed from the main thread. In the future, I think all layer tree host common tests will need to go down the property tree update path, but (in my opinion) it's not worth doing that until we have property trees everywhere. This patch is just a step in that direction to unblock property trees for the compositor thread first. R=ajuma@chromium.org,vollick@chromium.org BUG=481585 Committed: https://crrev.com/601f2ef11b664dfb8bffd8982de9d8afa560a8cc Cr-Commit-Position: refs/heads/master@{#330561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -32 lines) Patch
M cc/test/layer_tree_host_common_test.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/test/layer_tree_host_common_test.cc View 2 chunks +45 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 19 chunks +33 lines, -32 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
enne (OOO)
5 years, 7 months ago (2015-05-18 22:57:33 UTC) #1
ajuma
lgtm
5 years, 7 months ago (2015-05-19 13:17:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136643006/1
5 years, 7 months ago (2015-05-19 16:55:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 18:20:28 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:21:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/601f2ef11b664dfb8bffd8982de9d8afa560a8cc
Cr-Commit-Position: refs/heads/master@{#330561}

Powered by Google App Engine
This is Rietveld 408576698