Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1134743002: If marking deque allocation fails, try to make do with a smaller one (Closed)

Created:
5 years, 7 months ago by Erik Corry Chromium.org
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

If marking deque allocation fails, try to make do with a smaller one R=hpayer@chromium.org BUG= Committed: https://crrev.com/f3219552b60a924844f6f5ae2d219222309d93ad Cr-Commit-Position: refs/heads/master@{#28322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M src/heap/mark-compact.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +37 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Erik Corry Chromium.org
5 years, 7 months ago (2015-05-08 14:34:39 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-08 14:46:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134743002/1
5 years, 7 months ago (2015-05-08 14:47:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 15:12:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3219552b60a924844f6f5ae2d219222309d93ad Cr-Commit-Position: refs/heads/master@{#28322}
5 years, 7 months ago (2015-05-08 15:13:06 UTC) #6
Erik Corry
This is part of canary 2397
5 years, 7 months ago (2015-05-10 12:02:01 UTC) #8
Erik Corry
Unfortunately the crashes are still there and I can see why. This patch does not ...
5 years, 7 months ago (2015-05-10 21:59:12 UTC) #9
Erik Corry
5 years, 7 months ago (2015-05-11 19:46:30 UTC) #10
Message was sent while issue was closed.
New attempt at https://codereview.chromium.org/1133153003

Powered by Google App Engine
This is Rietveld 408576698