Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1133153003: Never uncommit the whole marking deque in case we can't get it back (Closed)

Created:
5 years, 7 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Never uncommit the whole marking deque in case we can't get it back R=hpayer@chromium.org BUG= Committed: https://crrev.com/98f45a409cb697cc0de65b937f08d96997520378 Cr-Commit-Position: refs/heads/master@{#28822}

Patch Set 1 #

Patch Set 2 : Don't accidentally wipe out the marking deque's overflow flag by reinitializing it #

Patch Set 3 : Remove failing assert. #

Patch Set 4 : Rebase #

Patch Set 5 : Fix that we were releasing the marking deque wrong when a new GC starts immediately #

Patch Set 6 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -70 lines) Patch
M src/heap/heap.cc View 1 2 3 4 5 2 chunks +11 lines, -6 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 5 6 chunks +25 lines, -17 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 7 chunks +70 lines, -46 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
Erik Corry Chromium.org
5 years, 7 months ago (2015-05-11 19:45:16 UTC) #1
Erik Corry
Previous version at https://codereview.chromium.org/1134743002/ would: * Reserve and commit 256k at start. * Try to ...
5 years, 7 months ago (2015-05-11 19:49:13 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-12 12:34:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153003/1
5 years, 7 months ago (2015-05-12 15:47:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/325)
5 years, 7 months ago (2015-05-12 16:00:10 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153003/20001
5 years, 7 months ago (2015-05-13 16:59:34 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/365)
5 years, 7 months ago (2015-05-13 17:12:41 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153003/40001
5 years, 7 months ago (2015-05-13 17:23:25 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/367)
5 years, 7 months ago (2015-05-13 17:37:19 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153003/80001
5 years, 7 months ago (2015-05-22 16:11:32 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/692)
5 years, 7 months ago (2015-05-22 16:28:24 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153003/100001
5 years, 6 months ago (2015-06-08 07:32:44 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 08:09:24 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133153003/100001
5 years, 6 months ago (2015-06-08 08:38:25 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-08 08:47:41 UTC) #31
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 08:47:58 UTC) #32
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/98f45a409cb697cc0de65b937f08d96997520378
Cr-Commit-Position: refs/heads/master@{#28822}

Powered by Google App Engine
This is Rietveld 408576698