Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed pre-submit warning Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h
index 56eaa852820d80f6cf86ea18dc609a4a8ff9607b..981569a23b9033b44515b4bd0d6303a7f44fd266 100644
--- a/content/renderer/push_messaging/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h
@@ -50,12 +50,12 @@ class PushMessagingDispatcher : public RenderFrameObserver,
blink::WebPushSubscriptionCallbacks* callbacks,
const Manifest& manifest);
- void OnRegisterFromDocumentSuccess(int32_t request_id,
- const GURL& endpoint,
- const std::string& registration_id);
+ void OnSubscribeFromDocumentSuccess(int32_t request_id,
+ const GURL& endpoint,
+ const std::string& subscription_id);
- void OnRegisterFromDocumentError(int32_t request_id,
- PushRegistrationStatus status);
+ void OnSubscribeFromDocumentError(int32_t request_id,
+ PushRegistrationStatus status);
IDMap<blink::WebPushSubscriptionCallbacks, IDMapOwnPointer>
subscription_callbacks_;
« no previous file with comments | « content/public/browser/push_messaging_service.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698