Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: content/public/browser/push_messaging_service.cc

Issue 1134733006: Push API: use (un)subscription instead of (un)registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed pre-submit warning Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/push_messaging_service.cc
diff --git a/content/public/browser/push_messaging_service.cc b/content/public/browser/push_messaging_service.cc
index 27335eb9adfbab9ca60bce7e78f50ae897fd6bb2..a1918ac0cbd5eaf8238d2b1090958010e82c52ea 100644
--- a/content/public/browser/push_messaging_service.cc
+++ b/content/public/browser/push_messaging_service.cc
@@ -67,7 +67,7 @@ void SetNotificationsShownOnIO(
base::Bind(&CallResultCallbackFromIO, callback));
}
-void ClearPushRegistrationIDOnIO(
+void ClearPushSubscriptionIDOnIO(
scoped_refptr<ServiceWorkerContextWrapper> service_worker_context,
int64 service_worker_registration_id,
const base::Closure& callback) {
@@ -142,7 +142,7 @@ void PushMessagingService::GetSenderId(BrowserContext* browser_context,
}
// static
-void PushMessagingService::ClearPushRegistrationID(
+void PushMessagingService::ClearPushSubscriptionID(
BrowserContext* browser_context,
const GURL& origin,
int64 service_worker_registration_id,
@@ -151,7 +151,7 @@ void PushMessagingService::ClearPushRegistrationID(
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
- base::Bind(&ClearPushRegistrationIDOnIO,
+ base::Bind(&ClearPushSubscriptionIDOnIO,
GetServiceWorkerContext(browser_context, origin),
service_worker_registration_id,
callback));
« no previous file with comments | « content/public/browser/push_messaging_service.h ('k') | content/renderer/push_messaging/push_messaging_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698