Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: LayoutTests/svg/repaint/svg-pathseglist-change.html

Issue 1134733005: SVG <use> should update when the referenced <path> is updating pathSegList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/repaint/svg-pathseglist-change.html
diff --git a/LayoutTests/svg/repaint/svg-length-rem-unit-font-size-change.html b/LayoutTests/svg/repaint/svg-pathseglist-change.html
similarity index 61%
copy from LayoutTests/svg/repaint/svg-length-rem-unit-font-size-change.html
copy to LayoutTests/svg/repaint/svg-pathseglist-change.html
index 3286f17ec22c7f5a7bd3887f083f6ae6c4d0fdce..1f2fff4834983454341e47162ad46eb6f758d285 100644
--- a/LayoutTests/svg/repaint/svg-length-rem-unit-font-size-change.html
+++ b/LayoutTests/svg/repaint/svg-pathseglist-change.html
@@ -1,5 +1,4 @@
<!DOCTYPE HTML>
-<html style="font-size:10px">
<script src="../../fast/repaint/resources/text-based-repaint.js"></script>
<script>
window.testIsAsync = true;
@@ -7,7 +6,7 @@ window.onload = runRepaintAndPixelTest;
function repaintTest() {
setTimeout(function() {
fs 2015/05/13 12:35:20 Why the setTimeout? (Not sure the rAF is needed ei
- document.getElementsByTagName("html")[0].style.fontSize="5px";
+ document.getElementById("path").pathSegList.getItem(2).y = 200;
fs 2015/05/13 12:35:21 I think we added "proper" indexing for pathseg lis
Shanmuga Pandi 2015/05/13 13:00:40 Done.
requestAnimationFrame(function() {
if (window.testRunner)
fs 2015/05/13 12:35:20 finishRepaintTest() checks this already.
Shanmuga Pandi 2015/05/13 13:00:39 removed
finishRepaintTest();
@@ -16,10 +15,9 @@ function repaintTest() {
};
</script>
<body>
-<div style="font-size:10px">
-<svg style="width:20rem; height:20rem;">
- <rect width="20rem" height="20em" style="fill:rgb(0,0,255);" />
+<svg height="200" width="300">
+ <path id="path" d="M50,50 L100,50 L100,100 Z" style="stroke: #006666; fill:none;"/>
fs 2015/05/13 12:35:21 How about just fill="green" instead - or is the st
Shanmuga Pandi 2015/05/13 13:00:40 Done.
+ <use xlink:href="#path" y="0" x="100"/>
fs 2015/05/13 12:35:20 Drop y="0" (it's the default)
Shanmuga Pandi 2015/05/13 13:00:40 Done.
</svg>
-</div>
</body>
</html>
« no previous file with comments | « no previous file | LayoutTests/svg/repaint/svg-pathseglist-change-expected.html » ('j') | Source/core/svg/SVGPathElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698