LayoutTests/svg/repaint/svg-pathseglist-change.html - Issue 1134733005: SVG <use> should update when the referenced <path> is updating pathSegList.

Side by Side Diff: LayoutTests/svg/repaint/svg-pathseglist-change.html

Issue 1134733005: SVG <use> should update when the referenced <path> is updating pathSegList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html style="font-size:10px">

3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>	2 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

4 <script>	3 <script>

5 window.testIsAsync = true;	4 window.testIsAsync = true;

6 window.onload = runRepaintAndPixelTest;	5 window.onload = runRepaintAndPixelTest;
	fs 2015/05/13 12:35:20 If this is indeed intended to be a repaint test, t If this is indeed intended to be a repaint test, then I think just runRepaintTest would suffice. If it's intended to be a ref-test then more changes will be needed. Shanmuga Pandi 2015/05/13 13:00:40 It is ref-test. So changed test case according to Show quoted text On 2015/05/13 12:35:20, fs wrote: > If this is indeed intended to be a repaint test, then I think just > runRepaintTest would suffice. If it's intended to be a ref-test then more > changes will be needed. It is ref-test. So changed test case according to it. fs 2015/05/13 13:20:51 Not sure svg/repaint/ is the best place for it (it Show quoted text On 2015/05/13 13:00:40, Shanmuga Pandi wrote: > On 2015/05/13 12:35:20, fs wrote: > > If this is indeed intended to be a repaint test, then I think just > > runRepaintTest would suffice. If it's intended to be a ref-test then more > > changes will be needed. > > It is ref-test. So changed test case according to it. Not sure svg/repaint/ is the best place for it (it's not actually a repaint bug right?). svg/custom/ has lots of use-* tests, so maybe that's a better place (and that prefix is certainly better.)
7	6

8 function repaintTest() {	7 function repaintTest() {

9 setTimeout(function() {	8 setTimeout(function() {
	fs 2015/05/13 12:35:20 Why the setTimeout? (Not sure the rAF is needed ei Why the setTimeout? (Not sure the rAF is needed either.)
10 document.getElementsByTagName("html")[0].style.fontSize="5px";	9 document.getElementById("path").pathSegList.getItem(2).y = 200;
	fs 2015/05/13 12:35:21 I think we added "proper" indexing for pathseg lis I think we added "proper" indexing for pathseg lists, so just pathSegList[2].y = ... should work as well (and is preferred - at least by me...) Shanmuga Pandi 2015/05/13 13:00:40 Done. Show quoted text On 2015/05/13 12:35:21, fs wrote: > I think we added "proper" indexing for pathseg lists, so just pathSegList[2].y = > ... should work as well (and is preferred - at least by me...) Done.
11 requestAnimationFrame(function() {	10 requestAnimationFrame(function() {

12 if (window.testRunner)	11 if (window.testRunner)
	fs 2015/05/13 12:35:20 finishRepaintTest() checks this already. finishRepaintTest() checks this already. Shanmuga Pandi 2015/05/13 13:00:39 removed Show quoted text On 2015/05/13 12:35:20, fs wrote: > finishRepaintTest() checks this already. removed
13 finishRepaintTest();	12 finishRepaintTest();

14 });	13 });

15 }, 0);	14 }, 0);

16 };	15 };

17 </script>	16 </script>

18 <body>	17 <body>

19 <div style="font-size:10px">	18 <svg height="200" width="300">

20 <svg style="width:20rem; height:20rem;">	19 <path id="path" d="M50,50 L100,50 L100,100 Z" style="stroke: #006666; fill:n one;"/>
	fs 2015/05/13 12:35:21 How about just fill="green" instead - or is the st How about just fill="green" instead - or is the stroke relevant in any way (doesn't look like it)? Shanmuga Pandi 2015/05/13 13:00:40 Done. Show quoted text On 2015/05/13 12:35:21, fs wrote: > How about just fill="green" instead - or is the stroke relevant in any way > (doesn't look like it)? Done.
21 <rect width="20rem" height="20em" style="fill:rgb(0,0,255);" />	20 <use xlink:href="#path" y="0" x="100"/>
	fs 2015/05/13 12:35:20 Drop y="0" (it's the default) Drop y="0" (it's the default) Shanmuga Pandi 2015/05/13 13:00:40 Done. Show quoted text On 2015/05/13 12:35:20, fs wrote: > Drop y="0" (it's the default) Done.
22 </svg>	21 </svg>

23 </div>

24 </body>	22 </body>

25 </html>	23 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/repaint/svg-pathseglist-change-expected.html » ('j') | Source/core/svg/SVGPathElement.cpp » ('J')