Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1134713004: [turbofan] Pass closure as node to FrameState. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pass closure as node to FrameState. First step towards support for inlining based on SharedFunctionInfo instead of JSFunction. R=jarin@chromium.org Committed: https://crrev.com/1643671f1b2c59e6eacdcf6f4602251cccfb6d7d Cr-Commit-Position: refs/heads/master@{#28419}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -137 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 5 chunks +27 lines, -22 lines 2 comments Download
M src/compiler/common-operator.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/compiler/frame-states.h View 2 chunks +6 lines, -13 lines 0 comments Download
M src/compiler/frame-states.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/instruction.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 3 chunks +3 lines, -16 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 8 chunks +51 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-15 10:51:53 UTC) #1
Benedikt Meurer
Hey Jaro, This is the initial part for TurboFan which we did in the morning. ...
5 years, 7 months ago (2015-05-15 10:52:29 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/1134713004/diff/1/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/1134713004/diff/1/src/compiler/code-generator.cc#newcode496 src/compiler/code-generator.cc:496: (1 + descriptor->parameters_count()))); Maybe we want a TODO ...
5 years, 7 months ago (2015-05-15 12:15:14 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1134713004/diff/1/src/compiler/code-generator.cc File src/compiler/code-generator.cc (right): https://codereview.chromium.org/1134713004/diff/1/src/compiler/code-generator.cc#newcode496 src/compiler/code-generator.cc:496: (1 + descriptor->parameters_count()))); Covered by TODO above.
5 years, 7 months ago (2015-05-15 12:15:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134713004/1
5 years, 7 months ago (2015-05-15 12:16:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 12:17:20 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 12:17:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1643671f1b2c59e6eacdcf6f4602251cccfb6d7d
Cr-Commit-Position: refs/heads/master@{#28419}

Powered by Google App Engine
This is Rietveld 408576698