Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1134643002: Add distinction between RGB and RGBA native texture video frames and resources (Closed)

Created:
5 years, 7 months ago by halliwell
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add distinction between RGB and RGBA native texture video frame and resources Currently it's impossible to place a NATIVE_TEXTURE VideoFrame into an overlay, because: * NATIVE_TEXTURE VideoFrame turns into RGB_RESOURCE in VideoResourceUpdater * RGB_RESOURCE always sets premultipled_alpha flag on its TextureDrawQuad (see VideoLayerImpl::AppendQuads) * OverlayStrategyCommon rejects quads with premultiplied alpha BUG= Committed: https://crrev.com/9e2b43aee24f3a9827e05d34578ba9a747236cd5 Cr-Commit-Position: refs/heads/master@{#329651}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/allows_overlay/allow_overlay #

Patch Set 3 : Rebase #

Patch Set 4 : Fix unit test breakage from bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M cc/layers/video_layer_impl.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/base/video_frame.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M media/base/video_frame.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M media/base/video_frame_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
halliwell
5 years, 7 months ago (2015-05-08 00:49:12 UTC) #2
danakj
LGTM
5 years, 7 months ago (2015-05-08 18:37:28 UTC) #3
halliwell
On 2015/05/08 18:37:28, danakj wrote: > LGTM xhwang@ or scherkus@ - ptal at media/ changes ...
5 years, 7 months ago (2015-05-12 15:27:30 UTC) #5
xhwang
media/ lgtm https://codereview.chromium.org/1134643002/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/1134643002/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode1249 content/renderer/media/android/webmediaplayer_android.cc:1249: base::TimeDelta(), false /* allows_overlay */, true /* ...
5 years, 7 months ago (2015-05-12 17:22:29 UTC) #6
halliwell
https://codereview.chromium.org/1134643002/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/1134643002/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode1249 content/renderer/media/android/webmediaplayer_android.cc:1249: base::TimeDelta(), false /* allows_overlay */, true /* has_alpha */); ...
5 years, 7 months ago (2015-05-12 17:50:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134643002/20001
5 years, 7 months ago (2015-05-12 17:56:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/52088) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-12 18:01:48 UTC) #12
halliwell
On 2015/05/12 18:01:48, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 7 months ago (2015-05-12 19:21:09 UTC) #13
xhwang
media/ still lgtm
5 years, 7 months ago (2015-05-12 19:50:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134643002/40001
5 years, 7 months ago (2015-05-13 14:53:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/71591)
5 years, 7 months ago (2015-05-13 15:04:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134643002/60001
5 years, 7 months ago (2015-05-13 15:32:31 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-13 16:27:29 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 16:28:13 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9e2b43aee24f3a9827e05d34578ba9a747236cd5
Cr-Commit-Position: refs/heads/master@{#329651}

Powered by Google App Engine
This is Rietveld 408576698