media/base/video_frame_unittest.cc - Issue 1134643002: Add distinction between RGB and RGBA native texture video frames and resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_frame_unittest.cc

Issue 1134643002: Add distinction between RGB and RGBA native texture video frames and resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test breakage from bad merge Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/video_frame_unittest.cc

diff --git a/media/base/video_frame_unittest.cc b/media/base/video_frame_unittest.cc

index 70379310cb3b7953cb602dcc4e70a82d097dc212..e22a8184228d814b6c2b5ea04c9dc653c7249555 100644

--- a/media/base/video_frame_unittest.cc

+++ b/media/base/video_frame_unittest.cc

@@ -258,7 +258,8 @@ TEST(VideoFrame, TextureNoLongerNeededCallbackIsCalled) {

gfx::Rect(10, 10), // visible_rect

gfx::Size(10, 10), // natural_size

base::TimeDelta(), // timestamp

- false); // allow_overlay

+ false, // allow_overlay

+ true); // has_alpha

EXPECT_EQ(VideoFrame::TEXTURE_RGBA, frame->texture_format());

}

// Nobody set a sync point to |frame|, so |frame| set |called_sync_point| to 0

« no previous file with comments | « media/base/video_frame.cc ('k') | media/filters/gpu_video_decoder.cc » ('j') | no next file with comments »