Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1134493002: Fix NSS locking bug when sending no_renegotiate. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NSS locking bug when sending no_renegotiate. See https://bugzilla.mozilla.org/show_bug.cgi?id=1162521. BUG=484543, 462283 Committed: https://crrev.com/3e6bbddd9984561c6e9216d1aadcc3231c043f12 Cr-Commit-Position: refs/heads/master@{#328795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M net/third_party/nss/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +1 line, -0 lines 0 comments Download
A net/third_party/nss/patches/norenegotiatelock.patch View 1 chunk +15 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
5 years, 7 months ago (2015-05-07 14:36:48 UTC) #2
Ryan Sleevi
lgtm
5 years, 7 months ago (2015-05-07 17:31:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134493002/1
5 years, 7 months ago (2015-05-07 17:33:34 UTC) #5
wtc
LGTM. I checked in David's patch upstream. It will appear in the NSS 3.19.1 release.
5 years, 7 months ago (2015-05-07 17:37:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 18:23:05 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 18:23:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e6bbddd9984561c6e9216d1aadcc3231c043f12
Cr-Commit-Position: refs/heads/master@{#328795}

Powered by Google App Engine
This is Rietveld 408576698