net/third_party/nss/ssl/ssl3con.c - Issue 1134493002: Fix NSS locking bug when sending no_renegotiate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/nss/ssl/ssl3con.c

Issue 1134493002: Fix NSS locking bug when sending no_renegotiate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/nss/ssl/ssl3con.c

diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con.c

index 424c1fb3a53911c17076175ec7305f49f0db9fd7..89c98eace8786bcf452dd9f1091c6aa5af4eefb2 100644

--- a/net/third_party/nss/ssl/ssl3con.c

+++ b/net/third_party/nss/ssl/ssl3con.c

@@ -5532,9 +5532,7 @@ ssl3_HandleHelloRequest(sslSocket *ss)

return SECFailure;

}

if (ss->opt.enableRenegotiation == SSL_RENEGOTIATE_NEVER) {

- ssl_GetXmitBufLock(ss);

- rv = SSL3_SendAlert(ss, alert_warning, no_renegotiation);

- ssl_ReleaseXmitBufLock(ss);

+ (void)SSL3_SendAlert(ss, alert_warning, no_renegotiation);

PORT_SetError(SSL_ERROR_RENEGOTIATION_NOT_ALLOWED);

return SECFailure;

}

« no previous file with comments | « net/third_party/nss/patches/norenegotiatelock.patch ('k') | no next file » | no next file with comments »