Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1811)

Issue 113443003: Disable library dependencies check by default (instrumented libs). (Closed)

Created:
7 years ago by alextaran1
Modified:
7 years ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Disable library dependencies check by default when build instrumented libraries. BUG=313751 R=glider@chromium.org TBR=cpu@chromium.org Installing all library dependencies using "apt-get build-dep" is not nesessary to build libraries. So, dependency checking will be shut down by default. All really nesessary dependencies will be added to "install-build-deps.sh". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241311

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 2 4 chunks +27 lines, -17 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alextaran1
Please take a quick look
7 years ago (2013-12-17 09:46:55 UTC) #1
alextaran1
Please take another look.
7 years ago (2013-12-17 14:07:03 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/113443003/diff/20001/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/113443003/diff/20001/third_party/instrumented_libraries/download_build_install.py#newcode136 third_party/instrumented_libraries/download_build_install.py:136: print "Probably, some of its dependencies are not installed: ...
7 years ago (2013-12-17 14:14:13 UTC) #3
alextaran1
Fixed. https://codereview.chromium.org/113443003/diff/20001/third_party/instrumented_libraries/download_build_install.py File third_party/instrumented_libraries/download_build_install.py (right): https://codereview.chromium.org/113443003/diff/20001/third_party/instrumented_libraries/download_build_install.py#newcode136 third_party/instrumented_libraries/download_build_install.py:136: print "Probably, some of its dependencies are not ...
7 years ago (2013-12-17 14:27:56 UTC) #4
Alexander Potapenko
LGTM
7 years ago (2013-12-17 14:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alextaran@chromium.org/113443003/40001
7 years ago (2013-12-17 14:34:23 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=41801
7 years ago (2013-12-17 14:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alextaran@chromium.org/113443003/40001
7 years ago (2013-12-17 15:00:11 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-17 17:34:32 UTC) #9
Message was sent while issue was closed.
Change committed as 241311

Powered by Google App Engine
This is Rietveld 408576698